Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_synapse_workspace_key: deprecate cusomter_managed_key_name in favour of the correctly spelled customer_managed_key_name #13881

Merged
merged 7 commits into from
Oct 29, 2021

Conversation

favoretti
Copy link
Collaborator

Fixes #13864

@@ -43,7 +43,7 @@ func resourceSynapseWorkspaceKey() *pluginsdk.Resource {
ValidateFunc: validate.WorkspaceID,
},

"cusomter_managed_key_name": {
"customer_managed_key_name": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sadly as mistaken as this name is the typo needs to be gracefully deprecated :( could we add a new property with the correct name and deprecate the old one? thanks

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sigh... Sure :)

@github-actions github-actions bot added size/S and removed size/XS labels Oct 28, 2021
@katbyte
Copy link
Collaborator

katbyte commented Oct 29, 2021

still a test failure:

------- Stdout: -------
=== RUN   TestAccSynapseWorkspaceKeys_customerManagedKey
=== PAUSE TestAccSynapseWorkspaceKeys_customerManagedKey
=== CONT  TestAccSynapseWorkspaceKeys_customerManagedKey
    testcase.go:109: Step 1/2 error: After applying this test step, the plan was not empty.
        stdout:
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # azurerm_synapse_workspace_key.test will be updated in-place
          ~ resource "azurerm_synapse_workspace_key" "test" {
              - customer_managed_key_name           = "test_key" -> null
                id                                  = "/subscriptions/*******/resourceGroups/acctestRG-synapse-211028201828209361/providers/Microsoft.Synapse/workspaces/acctestsw211028201828209361/keys/test_key"
                # (4 unchanged attributes hidden)
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccSynapseWorkspaceKeys_customerManagedKey (1020.13s)
FAIL

will need to mark them as computed

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed up and tests now pass, LGTM 🔥

@katbyte katbyte added this to the v2.84.0 milestone Oct 29, 2021
@katbyte katbyte changed the title azurerm_synapse_workspace_key: Fix argument name and docs azurerm_synapse_workspace_key: deprecate cusomter_managed_key_name in favour of the correctly spelled customer_managed_key_name Oct 29, 2021
@katbyte katbyte merged commit 031d9f6 into hashicorp:main Oct 29, 2021
katbyte added a commit that referenced this pull request Oct 29, 2021
@favoretti
Copy link
Collaborator Author

@katbyte Ohh... Thank you so much for fixing this!

@github-actions
Copy link

github-actions bot commented Nov 5, 2021

This functionality has been released in v2.84.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@TPPWC
Copy link

TPPWC commented Nov 8, 2021

Well the documentation is still wrong azurerm_synapse_workspace_keys and azurerm_synapse_workspace:

image

And also the key block is wrong in the documentation of the workspace and in the example of azurerm_synapse_workspace_keys:

image

image

cheers

tom

@github-actions
Copy link

github-actions bot commented Dec 9, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_synapse_workspace_key contain an argument with a typo and documentation not up-to-date
3 participants