-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_synapse_workspace_key
: deprecate cusomter_managed_key_name
in favour of the correctly spelled customer_managed_key_name
#13881
Conversation
@@ -43,7 +43,7 @@ func resourceSynapseWorkspaceKey() *pluginsdk.Resource { | |||
ValidateFunc: validate.WorkspaceID, | |||
}, | |||
|
|||
"cusomter_managed_key_name": { | |||
"customer_managed_key_name": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sadly as mistaken as this name is the typo needs to be gracefully deprecated :( could we add a new property with the correct name and deprecate the old one? thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sigh... Sure :)
still a test failure:
will need to mark them as computed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed up and tests now pass, LGTM 🔥
azurerm_synapse_workspace_key
: Fix argument name and docsazurerm_synapse_workspace_key
: deprecate cusomter_managed_key_name
in favour of the correctly spelled customer_managed_key_name
@katbyte Ohh... Thank you so much for fixing this! |
This functionality has been released in v2.84.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Fixes #13864